Skip to content

feat: public listing detail page supports external listings - #6525

Merged
mcgarrye merged 5 commits into
mainfrom
6367/support-for-external-listing-page
Jul 22, 2026
Merged

feat: public listing detail page supports external listings#6525
mcgarrye merged 5 commits into
mainfrom
6367/support-for-external-listing-page

Conversation

@mcgarrye

@mcgarrye mcgarrye commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR addresses #(6367)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

For external listings ingested by the system, they need to be displayed on the listing details page. To do this, the system fetches the live data from the external system. If the listing has a common app, it will reroute the user to the external site to apply.

How Can This Be Tested/Reviewed?

With Bloomington: Run yarn setup
With Bridge Bay: Run yarn db:setup:staging-region

Sign in as an admin through the partners site or the api
Through the api, call the /externalListings/ingest endpoint with the relevant data (found below)
On the public site, navigate to the listings browse page
Click on a internal listing, confirm listing detail page loads as expected. Click Apply now and confirm start page loads
Return to the listings browse page
Click on a external listing, confirm listing detail page loads as expected. Click Apply now and confirm you are redirected and start page loads

Call the ingest endpoint with the following payload, using the desired jurisdiction id to associate the listings with:
{ "externalURL": "https://hba-0-3-alameda-staging.herokuapp.com/", "jurisdictionId": "{id}", "targetName": "San Jose" }

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye
mcgarrye requested a review from ludtkemorgan July 16, 2026 18:58
@mcgarrye mcgarrye added the 1 review needed Requires 1 more review before ready to merge label Jul 16, 2026
@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 767b70e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a5fbe07e2bc350008b0a417

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 767b70e
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a5fbe060dab3600083bc263
😎 Deploy Preview https://deploy-preview-6525--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 767b70e
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a5fbe06110f1d0008ae5201
😎 Deploy Preview https://deploy-preview-6525--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ludtkemorgan ludtkemorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good after a padding is added to the new disclaimer

Comment thread shared-helpers/src/locales/general.json
Comment thread sites/public/src/components/listing/GetApplication.tsx
Comment thread sites/public/src/components/listing/listing_sections/Apply.tsx Outdated
@mcgarrye
mcgarrye requested a review from ludtkemorgan July 21, 2026 16:17
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jul 22, 2026
@mcgarrye
mcgarrye merged commit 9a99dd6 into main Jul 22, 2026
25 checks passed
@mcgarrye
mcgarrye deleted the 6367/support-for-external-listing-page branch July 22, 2026 20:27
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants